Skip to content

[#70] Fix broken for...in loop in yallApplyFn #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2019
Merged

[#70] Fix broken for...in loop in yallApplyFn #71

merged 1 commit into from
Nov 22, 2019

Conversation

Mobe91
Copy link
Contributor

@Mobe91 Mobe91 commented Oct 9, 2019

Fixes #70

@rkumorek
Copy link
Contributor

rkumorek commented Oct 10, 2019 •
edited
Loading

Just a suggestion but maybe we could switch to for...of loop instead to keep the codebase modernish together with the rest of the lib?

@Mobe91
Copy link
Contributor Author

Mobe91 commented Oct 10, 2019

Support for for...of does not look too good: https://caniuse.com/#search=for..

@malchata
Copy link
Owner

My bad in taking so long to review this. Life caught up with me.

Looks good. Nothing seems to break. I'll bring this in!

@malchata malchata merged commit 7509fc4 into malchata:master Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken loop in yallApplyFn
3 participants
@Mobe91 @rkumorek @malchata