Skip to content

Broken loop in yallApplyFn #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Mobe91 opened this issue Oct 9, 2019 · 0 comments · Fixed by #71
Closed

Broken loop in yallApplyFn #70

Mobe91 opened this issue Oct 9, 2019 · 0 comments · Fixed by #71

Comments

@Mobe91
Copy link
Contributor

Mobe91 commented Oct 9, 2019

yallApplyFn uses a for ... in loop to loop over an array. However, this loop also considers all enumerable object keys and not only array indices. This can break the intended functionality in cases where e.g. Array.prototype has been extended by custom keys.
Mobe91 added a commit to ordami/yall.js that referenced this issue Oct 9, 2019
@Mobe91
[malchata#70] Fix broken for...in loop in yallApplyFn
0688c88
@Mobe91 Mobe91 mentioned this issue Oct 9, 2019
Merged
malchata added a commit that referenced this issue Nov 22, 2019
@malchata
Merge pull request #71 from ordami/issues/70-yallApplyFn-broken-loop
7509fc4 
[#70] Fix broken for...in loop in yallApplyFn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#70] Fix broken for...in loop in yallApplyFn ordami/yall.js
1 participant
@Mobe91