Bugfix ie11 srcset #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
The same bug in Safari 9.1 (OS X El Capitan). |
|
Hey, sorry for delay @rkumorek. Been juggling a few things over here as of late. 🤡 If you could rebase your work on top of what is currently in master, I can review and merge this change if it doesn't cause any issues. |
|
Hey @malchata, I have rebased my branch on top of master and I hope it is all correct (my first contribution). Thanks |
|
I need to tweak a few things post-merge, but this otherwise looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
We've noticed recently on IE11 that line
element[dataAttr] = element.dataset[dataAttr]setssrcsetproperty on the element but it is not added as an attribute in DOM. This in turn doesn't allow us to use things likepicturefill.I can imagine the issue lies in IE11 not supporting srcset.
I am not sure if you're willing to go back to using
setAttributebut to fully support IE11 I think it would be nice to be able to usesrcset.Thanks