Skip to content

Npm scripts does not run on windows #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kalled opened this issue Jun 18, 2018 · 2 comments
Closed

Npm scripts does not run on windows #21

kalled opened this issue Jun 18, 2018 · 2 comments

Comments

@kalled
Copy link

kalled commented Jun 18, 2018

@malchata, are you interested in a pull request?

@malchata
Copy link
Owner

First off, my sincere apologies for not replying sooner. Life is currently throwing a lot at me to do. :)

Secondly, this is not something that's high on my list, for a number of reasons. First of which being that this addresses the developer experience, while the user experience is something I'm more interested in addressing (and am working on some bugs in that realm at the moment).

That said, if you have a solution, I'm interested, but acceptance of a PR is subject to these caveats:

  1. It can't break the current build process.
  2. It should not introduce significantly more packages.

Let me know what you think!

@kalled
Copy link
Author

kalled commented Jun 25, 2018

No worries, I feel ya! :)

It only introduces cross-var and mkdirp. I could not get show-sizes to print nicely in one line in the last build step so I had to remove it. I'll send a PR and hope that it makes it through.

About the user experience, I also found a couple a major issues, one quite hard to spot regarding not loading the correct sized image when using async image decode with srcset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants